From 132c7fe4a5f649a9f13dee756f7ab1c7d4a465bb Mon Sep 17 00:00:00 2001
From: teor <teor@riseup.net>
Date: Thu, 4 Feb 2021 08:36:34 +1000
Subject: [PATCH] Add a comment about a mempool request bug

Transaction verifier mempool requests should take the next block height,
because some consensus rules depend on the exact height.

See #1683.
---
 zebra-consensus/src/transaction.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/zebra-consensus/src/transaction.rs b/zebra-consensus/src/transaction.rs
index 52d48442..ae684ae9 100644
--- a/zebra-consensus/src/transaction.rs
+++ b/zebra-consensus/src/transaction.rs
@@ -79,7 +79,8 @@ pub enum Request {
         transaction: Arc<Transaction>,
         /// Additional UTXOs which are known at the time of verification.
         known_utxos: Arc<HashMap<transparent::OutPoint, zs::Utxo>>,
-        /// The active NU in the context of this verification.
+        /// Bug: this field should be the next block height, because some
+        /// consensus rules depend on the exact height. See #1683.
         upgrade: NetworkUpgrade,
     },
 }