octo
/
Zebra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make sure all RedPallas benchmarks sign and verify the same message

This commit is contained in:
Deirdre Connolly 2021-06-29 17:33:42 -04:00
parent edf0946208
commit 25cf199265
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
zebra-chain/benches/redpallas.rs
View File

@ -7,6 +7,8 @@ use rand::{thread_rng, Rng};
use zebra_chain::primitives::redpallas::*; use zebra_chain::primitives::redpallas::*;
const MESSAGE_BYTES: &[u8; 0] = b"";
/// A batch verification item of a RedPallas signature variant. /// A batch verification item of a RedPallas signature variant.
/// ///
/// This struct exists to allow batch processing to be decoupled from the /// This struct exists to allow batch processing to be decoupled from the
@ -31,18 +33,18 @@ enum Item {
fn sigs_with_distinct_keys() -> impl Iterator<Item = Item> { fn sigs_with_distinct_keys() -> impl Iterator<Item = Item> {
std::iter::repeat_with(|| { std::iter::repeat_with(|| {
let mut rng = thread_rng(); let mut rng = thread_rng();
let msg = b""; // let msg = b"";
match rng.gen::<u8>() % 2 { match rng.gen::<u8>() % 2 {
0 => { 0 => {
let sk = SigningKey::<SpendAuth>::new(thread_rng()); let sk = SigningKey::<SpendAuth>::new(thread_rng());
let vk_bytes = VerificationKey::from(&sk).into(); let vk_bytes = VerificationKey::from(&sk).into();
let sig = sk.sign(thread_rng(), &msg[..]); let sig = sk.sign(thread_rng(), &MESSAGE_BYTES[..]);
Item::SpendAuth { vk_bytes, sig } Item::SpendAuth { vk_bytes, sig }
} }
1 => { 1 => {
let sk = SigningKey::<Binding>::new(thread_rng()); let sk = SigningKey::<Binding>::new(thread_rng());
let vk_bytes = VerificationKey::from(&sk).into(); let vk_bytes = VerificationKey::from(&sk).into();
let sig = sk.sign(thread_rng(), &msg[..]); let sig = sk.sign(thread_rng(), &MESSAGE_BYTES[..]);
Item::Binding { vk_bytes, sig } Item::Binding { vk_bytes, sig }
} }
_ => panic!(), _ => panic!(),
@ -66,15 +68,14 @@ fn bench_batch_verify(c: &mut Criterion) {
|b, sigs| { |b, sigs| {
b.iter(|| { b.iter(|| {
for item in sigs.iter() { for item in sigs.iter() {
let msg = b"Bench";
match item { match item {
Item::SpendAuth { vk_bytes, sig } => { Item::SpendAuth { vk_bytes, sig } => {
let _ = VerificationKey::try_from(*vk_bytes) let _ = VerificationKey::try_from(*vk_bytes)
.and_then(|vk| vk.verify(msg, sig)); .and_then(|vk| vk.verify(MESSAGE_BYTES, sig));
} }
Item::Binding { vk_bytes, sig } => { Item::Binding { vk_bytes, sig } => {
let _ = VerificationKey::try_from(*vk_bytes) let _ = VerificationKey::try_from(*vk_bytes)
.and_then(|vk| vk.verify(msg, sig)); .and_then(|vk| vk.verify(MESSAGE_BYTES, sig));
} }
} }
} }
@ -89,13 +90,12 @@ fn bench_batch_verify(c: &mut Criterion) {
b.iter(|| { b.iter(|| {
let mut batch = batch::Verifier::new(); let mut batch = batch::Verifier::new();
for item in sigs.iter() { for item in sigs.iter() {
let msg = b"Bench";
match item { match item {
Item::SpendAuth { vk_bytes, sig } => { Item::SpendAuth { vk_bytes, sig } => {
batch.queue((*vk_bytes, *sig, msg)); batch.queue((*vk_bytes, *sig, MESSAGE_BYTES));
} }
Item::Binding { vk_bytes, sig } => { Item::Binding { vk_bytes, sig } => {
batch.queue((*vk_bytes, *sig, msg)); batch.queue((*vk_bytes, *sig, MESSAGE_BYTES));
} }
} }
} }