octo
/
Zebra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Expand the template testing section (#1157) 

Based on team discussions
This commit is contained in:
teor 2020-10-15 05:08:52 +10:00 committed by GitHub
parent 15d0e127fd
commit 351e5013ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
book/src/dev/rfcs/0000-template.md
View File

@ -52,10 +52,17 @@ Explain how the feature will be tested, including:
* tests for consensus-critical functionality * tests for consensus-critical functionality
* existing test vectors, if available * existing test vectors, if available
* Zcash blockchain block test vectors (specify the network upgrade, feature, or block height and network) * Zcash blockchain block test vectors (specify the network upgrade, feature, or block height and network)
* property testing or fuzzing
The tests should cover: The tests should cover:
* positive cases: make sure the feature accepts valid inputs * positive cases: make sure the feature accepts valid inputs
* using block test vectors for each network upgrade provides some coverage of valid inputs
* negative cases: make sure the feature rejects invalid inputs * negative cases: make sure the feature rejects invalid inputs
* make sure there is a test case for each error condition in the code
* if there are lots of potential errors, prioritise:
* consensus-critical errors
* security-critical errors, and
* likely errors
* edge cases: make sure that boundary conditions are correctly handled * edge cases: make sure that boundary conditions are correctly handled
# Drawbacks # Drawbacks