From 4914b80cdb396935ac36bac2cf3330c276af9888 Mon Sep 17 00:00:00 2001
From: Deirdre Connolly <deirdre@zfnd.org>
Date: Wed, 12 Aug 2020 02:35:40 -0400
Subject: [PATCH] Add a TODO about caching Pedersen hash generator points

---
 zebra-chain/src/commitments/sapling.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/zebra-chain/src/commitments/sapling.rs b/zebra-chain/src/commitments/sapling.rs
index 0172abda..d6aca751 100644
--- a/zebra-chain/src/commitments/sapling.rs
+++ b/zebra-chain/src/commitments/sapling.rs
@@ -205,6 +205,8 @@ impl ValueCommitment {
         let v = jubjub::Fr::from(value);
         let rcv = generate_trapdoor(csprng);
 
+        // TODO: These generator points can be generated once somewhere else to
+        // avoid having to recompute them on every new commitment.
         let V = find_group_hash(*b"Zcash_cv", b"v");
         let R = find_group_hash(*b"Zcash_cv", b"r");