octo
/
Zebra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove test attributes and allow(dead_code) for test code that tests currently unimplemented functionality

This commit is contained in:
Deirdre Connolly 2020-11-21 01:37:43 -05:00 committed by Deirdre Connolly
parent 036abd50ac
commit 558661a531
3 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/test.yml vendored
View File

@ -63,7 +63,7 @@ jobs:
- name: Run all tests - name: Run all tests
run: | run: |
gcloud compute ssh "zebrad-tests-$BRANCH_NAME-$SHORT_SHA" --zone "$ZONE" \ gcloud compute ssh "zebrad-tests-$BRANCH_NAME-$SHORT_SHA" --zone "$ZONE" \
--command "git clone -b $BRANCH_NAME https://github.com/ZcashFoundation/zebra.git; cd zebra/; docker build -f docker/Dockerfile.test -t zebrad-test .; docker run -i zebrad-test cargo test --workspace --no-fail-fast -- -Zunstable-options --include-ignored --skip kill_on_timeout" --command "git clone -b $BRANCH_NAME https://github.com/ZcashFoundation/zebra.git; cd zebra/; docker build -f docker/Dockerfile.test -t zebrad-test .; docker run -i zebrad-test cargo test --workspace --no-fail-fast -- -Zunstable-options --include-ignored"
# Clean up # Clean up
- name: Delete test instance - name: Delete test instance

6
zebra-consensus/src/block/tests.rs
View File

@ -102,13 +102,15 @@ static INVALID_COINBASE_TRANSCRIPT: Lazy<Vec<(Arc<Block>, Result<block::Hash, Tr
] ]
}); });
#[tokio::test]
// TODO: enable this test after implementing contextual verification // TODO: enable this test after implementing contextual verification
#[ignore] // #[tokio::test]
// #[ignore]
#[allow(dead_code)]
async fn check_transcripts_test() -> Result<(), Report> { async fn check_transcripts_test() -> Result<(), Report> {
check_transcripts().await check_transcripts().await
} }
#[allow(dead_code)]
#[spandoc::spandoc] #[spandoc::spandoc]
async fn check_transcripts() -> Result<(), Report> { async fn check_transcripts() -> Result<(), Report> {
zebra_test::init(); zebra_test::init();

6
zebra-consensus/src/checkpoint/tests.rs
View File

@ -213,9 +213,9 @@ async fn multi_item_checkpoint_list() -> Result<(), Report> {
Ok(()) Ok(())
} }
#[tokio::test]
// Temporarily ignore this test, until the state can handle out-of-order blocks // Temporarily ignore this test, until the state can handle out-of-order blocks
#[ignore] // #[tokio::test]
#[allow(dead_code)]
async fn continuous_blockchain_test() -> Result<(), Report> { async fn continuous_blockchain_test() -> Result<(), Report> {
continuous_blockchain(None).await?; continuous_blockchain(None).await?;
for height in 0..=10 { for height in 0..=10 {
@ -225,6 +225,8 @@ async fn continuous_blockchain_test() -> Result<(), Report> {
} }
/// Test a continuous blockchain, restarting verification at `restart_height`. /// Test a continuous blockchain, restarting verification at `restart_height`.
// TODO: does this duplicate the test code commented out in src/chain/tests.rs?
#[allow(dead_code)]
#[spandoc::spandoc] #[spandoc::spandoc]
async fn continuous_blockchain(restart_height: Option<block::Height>) -> Result<(), Report> { async fn continuous_blockchain(restart_height: Option<block::Height>) -> Result<(), Report> {
zebra_test::init(); zebra_test::init();