From 6a84094b120d78b53e52d7a6a921eedf6886c5db Mon Sep 17 00:00:00 2001 From: teor Date: Thu, 19 Aug 2021 22:44:38 +1000 Subject: [PATCH] Fix a clippy::collapsible_match lint (#2642) We don't use the suggestion here, because it's actually wrong. See https://github.com/rust-lang/rust-clippy/issues/7575 --- zebra-consensus/src/transaction/tests.rs | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/zebra-consensus/src/transaction/tests.rs b/zebra-consensus/src/transaction/tests.rs index 7fadfb95..039f8493 100644 --- a/zebra-consensus/src/transaction/tests.rs +++ b/zebra-consensus/src/transaction/tests.rs @@ -44,21 +44,15 @@ fn v5_fake_transactions() -> Result<(), Report> { check::coinbase_tx_no_prevout_joinsplit_spend(&transaction)?; // validate the sapling shielded data - match transaction { - Transaction::V5 { - sapling_shielded_data, - .. - } => { - if let Some(s) = sapling_shielded_data { - for spend in s.spends_per_anchor() { - check::spend_cv_rk_not_small_order(&spend)? - } - for output in s.outputs() { - check::output_cv_epk_not_small_order(output)?; - } - } + if transaction.version() == 5 { + for spend in transaction.sapling_spends_per_anchor() { + check::spend_cv_rk_not_small_order(&spend)?; } - _ => panic!("we should have no tx other than 5"), + for output in transaction.sapling_outputs() { + check::output_cv_epk_not_small_order(output)?; + } + } else { + panic!("we should have no tx other than 5"); } } }