From 85f113bc1809f018ab1d121ac83918e0818cf61d Mon Sep 17 00:00:00 2001 From: teor Date: Wed, 22 Jul 2020 22:10:59 +1000 Subject: [PATCH] doc: Add a TODO to the network protocol --- zebra-network/src/protocol/external/types.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/zebra-network/src/protocol/external/types.rs b/zebra-network/src/protocol/external/types.rs index e674cbdf..8fd33815 100644 --- a/zebra-network/src/protocol/external/types.rs +++ b/zebra-network/src/protocol/external/types.rs @@ -39,7 +39,8 @@ impl Version { /// Returns the minimum network protocol version for `network` and /// `network_upgrade`. pub fn min_version(network: Network, network_upgrade: NetworkUpgrade) -> Self { - // We might not ever use these older versions. + // TODO: Should we reject earlier protocol versions during our initial + // sync? zcashd accepts 170_002 or later during its initial sync. Version(match (network, network_upgrade) { (_, BeforeOverwinter) => 170_002, (Testnet, Overwinter) => 170_003,