octo
/
Zebra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

network: don't fail on unsolicited messages 

These messages might be unsolicited, or they might be a response to a
request we already canceled.  So don't fail the whole connection, just
drop the message and move on.
This commit is contained in:
Henry de Valence 2020-09-22 11:28:32 -07:00
parent 13daefa729
commit 8e709bfa88
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
zebra-network/src/peer/connection.rs
View File

@ -582,25 +582,26 @@ where
} }
// These messages should already be handled as a response if they // These messages should already be handled as a response if they
// could be a response, so if we see them here, they were either // could be a response, so if we see them here, they were either
// sent unsolicited, or we've failed to handle messages correctly. // sent unsolicited, or they were sent in response to a canceled request
// that we've already forgotten about.
Message::Reject { .. } => { Message::Reject { .. } => {
self.fail_with(PeerError::WrongMessage("unsolicited reject message")); tracing::debug!("got reject message unsolicited or from canceled request");
return; return;
} }
Message::NotFound { .. } => { Message::NotFound { .. } => {
self.fail_with(PeerError::WrongMessage("unsolicited notfound message")); tracing::debug!("got notfound message unsolicited or from canceled request");
return; return;
} }
Message::Pong(_) => { Message::Pong(_) => {
self.fail_with(PeerError::WrongMessage("unsolicited pong message")); tracing::debug!("got pong message unsolicited or from canceled request");
return; return;
} }
Message::Block(_) => { Message::Block(_) => {
self.fail_with(PeerError::WrongMessage("unsolicited block message")); tracing::debug!("got block message unsolicited or from canceled request");
return; return;
} }
Message::Headers(_) => { Message::Headers(_) => {
self.fail_with(PeerError::WrongMessage("unsolicited headers message")); tracing::debug!("got headers message unsolicited or from canceled request");
return; return;
} }
// These messages should never be sent by peers. // These messages should never be sent by peers.