From 8f838166a86be1a4516b2764906f106d77ee3e66 Mon Sep 17 00:00:00 2001 From: teor Date: Wed, 11 Nov 2020 00:45:53 +1000 Subject: [PATCH] Make ExpandedDifficulty Debug byte order match Hash Bugfix on PR #1171. --- zebra-chain/src/work/difficulty.rs | 2 +- zebra-chain/src/work/difficulty/tests/vectors.rs | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/zebra-chain/src/work/difficulty.rs b/zebra-chain/src/work/difficulty.rs index 6443e2b2..846583eb 100644 --- a/zebra-chain/src/work/difficulty.rs +++ b/zebra-chain/src/work/difficulty.rs @@ -98,7 +98,7 @@ impl fmt::Debug for ExpandedDifficulty { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { let mut buf = [0; 32]; // Use the same byte order as block::Hash - self.0.to_little_endian(&mut buf); + self.0.to_big_endian(&mut buf); f.debug_tuple("ExpandedDifficulty") .field(&hex::encode(&buf)) .finish() diff --git a/zebra-chain/src/work/difficulty/tests/vectors.rs b/zebra-chain/src/work/difficulty/tests/vectors.rs index a906b8e3..9379c88a 100644 --- a/zebra-chain/src/work/difficulty/tests/vectors.rs +++ b/zebra-chain/src/work/difficulty/tests/vectors.rs @@ -36,7 +36,7 @@ fn debug_format() { ); assert_eq!( format!("{:?}", ExpandedDifficulty(U256::one())), - "ExpandedDifficulty(\"0100000000000000000000000000000000000000000000000000000000000000\")" + "ExpandedDifficulty(\"0000000000000000000000000000000000000000000000000000000000000001\")" ); assert_eq!( format!("{:?}", ExpandedDifficulty(U256::MAX)), @@ -44,6 +44,7 @@ fn debug_format() { ); assert_eq!(format!("{:?}", Work(0)), "Work(0x0, 0, -inf)"); + assert_eq!(format!("{:?}", Work(1)), "Work(0x1, 1, 0.00000)"); assert_eq!( format!("{:?}", Work(u8::MAX as u128)), "Work(0xff, 255, 7.99435)"