From 966430d400d251d17d256691a2837a43e14ce1bc Mon Sep 17 00:00:00 2001 From: Janito Vaqueiro Ferreira Filho Date: Wed, 26 May 2021 19:09:02 -0300 Subject: [PATCH] Update security note to be broader Focus on what can go wrong, and not on the specific causes. Co-authored-by: teor --- zebra-network/src/peer_set/candidate_set.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/zebra-network/src/peer_set/candidate_set.rs b/zebra-network/src/peer_set/candidate_set.rs index 2402ee23..9c6d73d3 100644 --- a/zebra-network/src/peer_set/candidate_set.rs +++ b/zebra-network/src/peer_set/candidate_set.rs @@ -337,9 +337,7 @@ where /// malicious peers keeping all their addresses at the front of the connection /// queue. Honest peers with future clock skew also get adjusted. /// -/// Rejects all addresses if there are at least two that have reported -/// last_seen` times where one is so far in the future and another is so far in -/// the past that they cause an overflow when offsetting the times. +/// Rejects all addresses if any calculated times overflow or underflow. fn validate_addrs( addrs: impl IntoIterator, last_seen_limit: DateTime32,