From 9e2ff23d542fcea5cab9862f0db378eb3f68d553 Mon Sep 17 00:00:00 2001 From: Henry de Valence Date: Sat, 19 Sep 2020 23:58:41 -0700 Subject: [PATCH] consensus, state: increase Buffer sizes Using a Buffer with size 1 is a footgun because it allows only one sender to call poll_ready at a time. This is usually undesirable because it means that a task or service that calls poll_ready but only makes a service call later (potentially much later) will block all other callers. --- zebra-consensus/src/chain.rs | 2 +- zebra-state/src/service.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/zebra-consensus/src/chain.rs b/zebra-consensus/src/chain.rs index 62873400..79abe5c7 100644 --- a/zebra-consensus/src/chain.rs +++ b/zebra-consensus/src/chain.rs @@ -152,6 +152,6 @@ where max_checkpoint_height, last_block_height: None, }), - 1, + 3, ) } diff --git a/zebra-state/src/service.rs b/zebra-state/src/service.rs index 9e688c05..7c14ad68 100644 --- a/zebra-state/src/service.rs +++ b/zebra-state/src/service.rs @@ -104,5 +104,5 @@ pub fn init( config: Config, network: Network, ) -> Buffer, Request> { - Buffer::new(BoxService::new(StateService::new(config, network)), 1) + Buffer::new(BoxService::new(StateService::new(config, network)), 3) }