From a52178cfe7a1bc79efa04c8fa84bbd04ac2c1f20 Mon Sep 17 00:00:00 2001 From: teor Date: Thu, 11 May 2023 10:59:19 +1000 Subject: [PATCH] Run all the duplicate dependency checks even if one fails (#6660) --- .github/workflows/continous-integration-os.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/continous-integration-os.yml b/.github/workflows/continous-integration-os.yml index df7e898a..24178d52 100644 --- a/.github/workflows/continous-integration-os.yml +++ b/.github/workflows/continous-integration-os.yml @@ -250,6 +250,8 @@ jobs: - bans - sources features: ['', '--all-features', '--no-default-features'] + # We always want to run the --all-features job, because it gives accurate "skip tree root was not found" warnings + fail-fast: false # Prevent sudden announcement of a new advisory from failing ci: continue-on-error: ${{ matrix.checks == 'advisories' }} @@ -259,8 +261,8 @@ jobs: with: persist-credentials: false - # this check also runs with optional features off - # so we expect some warnings about "skip tree root was not found" + # The --all-features job is the only job that gives accurate "skip tree root was not found" warnings. + # In other jobs, we expect some of these warnings, due to disabled features. - name: Check ${{ matrix.checks }} with features ${{ matrix.features }} uses: EmbarkStudios/cargo-deny-action@v1 with: