octo
/
Zebra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

change(release): Add more cargo clean to the release checklist (#6964) 

* Add more cargo clean to the release checklist

* Add locked to the install command
This commit is contained in:
teor 2023-06-17 02:32:21 +10:00 committed by GitHub
parent 06a27ed937
commit b199a3008d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
.github/PULL_REQUEST_TEMPLATE/release-checklist.md vendored
View File

@ -57,7 +57,8 @@ Zebra's Rust API doesn't have any support or stability guarantees, so we keep al
</details> </details>
- [ ] Update crate versions and do a release dry-run: - [ ] Update crate versions and do a release dry-run
- [ ] `cargo clean` (optional)
- [ ] `cargo release version --verbose --execute --workspace --exclude zebrad beta` - [ ] `cargo release version --verbose --execute --workspace --exclude zebrad beta`
- [ ] `cargo release version --verbose --execute --package zebrad [ major | minor | patch ]` - [ ] `cargo release version --verbose --execute --package zebrad [ major | minor | patch ]`
- [ ] `cargo release publish --verbose --dry-run --workspace` - [ ] `cargo release publish --verbose --dry-run --workspace`
@ -149,15 +150,16 @@ The end of support height is calculated from the current blockchain height:
## Publish Crates ## Publish Crates
- [ ] Run `cargo login` - [ ] Run `cargo login`
- [ ] Run `cargo clean` in the zebra repo - [ ] Run `cargo clean` in the zebra repo (optional)
- [ ] Publish the crates to crates.io: `cargo release publish --verbose --workspace --execute` - [ ] Publish the crates to crates.io: `cargo release publish --verbose --workspace --execute`
- [ ] Check that Zebra can be installed from `crates.io`: - [ ] Check that Zebra can be installed from `crates.io`:
`cargo install --force --version 1.0.0 zebrad && ~/.cargo/bin/zebrad` `cargo install --locked --force --version 1.0.0 zebrad && ~/.cargo/bin/zebrad`
and put the output in a comment on the PR.
## Publish Docker Images ## Publish Docker Images
- [ ] Wait until [the Docker images have been published](https://github.com/ZcashFoundation/zebra/actions/workflows/release-binaries.yml) - [ ] Wait until [the Docker images have been published](https://github.com/ZcashFoundation/zebra/actions/workflows/release-binaries.yml)
- [ ] Test the Docker image using `docker run --tty --interactive zfnd/zebra:v1.0.0`, - [ ] Test the Docker image using `docker run --tty --interactive zfnd/zebra:v1.0.0`,
and put the output in a comment on the PR. and put the output in a comment on the PR.
(You can use [gcloud cloud shell](https://console.cloud.google.com/home/dashboard?cloudshell=true)) (You can use [gcloud cloud shell](https://console.cloud.google.com/home/dashboard?cloudshell=true))
- [ ] Un-freeze the [`batched` queue](https://dashboard.mergify.com/github/ZcashFoundation/repo/zebra/queues) using Mergify. - [ ] Un-freeze the [`batched` queue](https://dashboard.mergify.com/github/ZcashFoundation/repo/zebra/queues) using Mergify.