From b891a96a6d5347adee38b80ed6678e372e8f957d Mon Sep 17 00:00:00 2001 From: Janito Vaqueiro Ferreira Filho Date: Fri, 21 May 2021 21:41:26 +0000 Subject: [PATCH] Improve ergonomics by returning `impl Iterator` Returning `impl IntoIterator` means that the caller will always be forced to call `.into_iter()`, and returning `impl Iterator` still allows them to call `.into_iter()` because it becomes the identity function. --- zebra-network/src/peer_set/candidate_set.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zebra-network/src/peer_set/candidate_set.rs b/zebra-network/src/peer_set/candidate_set.rs index be51be48..3e0cc8de 100644 --- a/zebra-network/src/peer_set/candidate_set.rs +++ b/zebra-network/src/peer_set/candidate_set.rs @@ -335,7 +335,7 @@ where fn validate_addrs( addrs: impl IntoIterator, last_seen_limit: DateTime, -) -> impl IntoIterator { +) -> impl Iterator { // Note: The address book handles duplicate addresses internally, // so we don't need to de-duplicate addresses here. @@ -348,5 +348,5 @@ fn validate_addrs( // - Zebra should limit the number of addresses it uses from a single Addrs // response (#1869) - addrs + addrs.into_iter() }