octo
/
Zebra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Adjust bounds on the LockTime Arbitrary impl 

The previous code could generate LockTime::Time with (u32::MAX + 1),
but the maximum valid value is u32::MAX due to the field size.
This commit is contained in:
teor 2020-07-01 12:55:00 +10:00
parent 00e750654a
commit c8829d8408
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zebra-chain/src/types.rs
View File

@ -79,8 +79,8 @@ impl Arbitrary for LockTime {
fn arbitrary_with(_args: ()) -> Self::Strategy { fn arbitrary_with(_args: ()) -> Self::Strategy {
prop_oneof![ prop_oneof![
(0u32..500_000_000_u32).prop_map(|n| LockTime::Height(BlockHeight(n))), (0u32..500_000_000_u32).prop_map(|n| LockTime::Height(BlockHeight(n))),
// XXX Setting max to i64::MAX doesn't work, this is 2**32. // LockTime is u32 in the spec, so we are limited to u32::MAX here
(500_000_000i64..4_294_967_296).prop_map(|n| { LockTime::Time(Utc.timestamp(n, 0)) }) (500_000_000..u32::MAX).prop_map(|n| { LockTime::Time(Utc.timestamp(n as i64, 0)) })
] ]
.boxed() .boxed()
} }