From c9ca601cff2b83ba227f371f133495077e09b984 Mon Sep 17 00:00:00 2001 From: teor Date: Tue, 16 Feb 2021 19:37:26 +1000 Subject: [PATCH] Revert "Change skip network test name and comments" This reverts commit f85006a798a98c11c5f18160ec61a36c324c73cb. --- .github/workflows/ci.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e9e9b9d4..eee60e7b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -34,11 +34,10 @@ jobs: - name: Install LLVM on Windows if: matrix.os == 'windows-latest' run: choco install llvm -y - - name: Run network tests only on macOS - # Only macOS runners have all network capabilities: - # https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners#cloud-hosts-for-github-hosted-runners - # Tests that only check launch behaviour or local port binding are not skipped in any platform. - if: matrix.os != 'macOS-latest' + - name: Skip network tests on Ubuntu and Windows + # Ubuntu runners don't have network or DNS configured during test steps + # Windows runners have an unreliable network + if: matrix.os == 'ubuntu-latest' || matrix.os == 'windows-latest' run: echo "ZEBRA_SKIP_NETWORK_TESTS=1" >> $GITHUB_ENV - name: Run tests env: