octo
/
Zebra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Document how outbound handshakes are rate-limited (#7976)

This commit is contained in:
teor 2023-11-24 07:58:59 +10:00 committed by GitHub
parent 382fb3775a
commit ca062d04d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
zebra-network/src/peer_set/candidate_set.rs
View File

@ -368,7 +368,8 @@ where
/// Zebra resists distributed denial of service attacks by making sure that /// Zebra resists distributed denial of service attacks by making sure that
/// new peer connections are initiated at least /// new peer connections are initiated at least
/// [`MIN_OUTBOUND_PEER_CONNECTION_INTERVAL`][constants::MIN_OUTBOUND_PEER_CONNECTION_INTERVAL] /// [`MIN_OUTBOUND_PEER_CONNECTION_INTERVAL`][constants::MIN_OUTBOUND_PEER_CONNECTION_INTERVAL]
/// apart. /// apart. If `next()` has recently provided a peer, then its future will sleep
/// until the rate-limit has passed.
/// ///
/// [`Responded`]: crate::PeerAddrState::Responded /// [`Responded`]: crate::PeerAddrState::Responded
pub async fn next(&mut self) -> Option<MetaAddr> { pub async fn next(&mut self) -> Option<MetaAddr> {

6
zebra-network/src/peer_set/initialize.rs
View File

@ -870,6 +870,12 @@ where
// Spawn each handshake or crawl into an independent task, so handshakes can make // Spawn each handshake or crawl into an independent task, so handshakes can make
// progress while crawls are running. // progress while crawls are running.
//
// # Concurrency
//
// The peer crawler must be able to make progress even if some handshakes are
// rate-limited. So the async mutex and next peer timeout are awaited inside the
// spawned task.
let handshake_or_crawl_handle = tokio::spawn( let handshake_or_crawl_handle = tokio::spawn(
async move { async move {
// Try to get the next available peer for a handshake. // Try to get the next available peer for a handshake.