From cc7d5bd2adea1fee9c9092f0438c5b04d5cf91b3 Mon Sep 17 00:00:00 2001 From: teor Date: Tue, 16 Feb 2021 06:14:40 +1000 Subject: [PATCH] Update comments for the inbound service (#1740) --- zebrad/src/components/inbound.rs | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/zebrad/src/components/inbound.rs b/zebrad/src/components/inbound.rs index e2f0ed39..283bbd7b 100644 --- a/zebrad/src/components/inbound.rs +++ b/zebrad/src/components/inbound.rs @@ -69,9 +69,6 @@ pub enum Setup { /// Network setup failed, because the setup channel permanently failed. /// The service keeps returning readiness errors for every request. - /// - /// We keep hold of the closed oneshot, so we can use it to create a - /// new error for each `poll_ready` call. FailedRecv { error: SharedRecvError }, } @@ -221,8 +218,8 @@ impl Service for Inbound { // "load shed directly" pattern from #1618. // * currently, the state service is always ready, unless its buffer is full. // So we might also want to propagate backpressure from its buffer. - // * if we want to propagate backpressure, add a ReadyCache for each service, to ensure - // that each poll_ready has a matching call. See #1593 for details. + // * poll_ready needs to be implemented carefully, to avoid hangs or deadlocks. + // See #1593 for details. Poll::Ready(result) }