From f85006a798a98c11c5f18160ec61a36c324c73cb Mon Sep 17 00:00:00 2001 From: Alfredo Garcia Date: Mon, 15 Feb 2021 09:41:21 -0300 Subject: [PATCH] Change skip network test name and comments --- .github/workflows/ci.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 58c611b3..0bf19dbf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -27,10 +27,11 @@ jobs: - name: Install LLVM on Windows if: matrix.os == 'windows-latest' run: choco install llvm -y - - name: Skip network tests on Ubuntu and Windows - # Ubuntu runners don't have network or DNS configured during test steps - # Windows runners have an unreliable network - if: matrix.os == 'ubuntu-latest' || matrix.os == 'windows-latest' + - name: Run network tests only on macOS + # Only macOS runners have all network capabilities: + # https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners#cloud-hosts-for-github-hosted-runners + # Tests that only check launch behaviour or local port binding are not skipped in any platform. + if: matrix.os != 'macOS-latest' run: echo "ZEBRA_SKIP_NETWORK_TESTS=1" >> $GITHUB_ENV - name: Run tests env: