From f8693ee00466f4252b22eee65dfeb42b63b667e6 Mon Sep 17 00:00:00 2001 From: teor Date: Wed, 12 May 2021 18:42:48 +1000 Subject: [PATCH] Explain how to review version bump PRs (#2138) --- .github/PULL_REQUEST_TEMPLATE/release-checklist.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE/release-checklist.md b/.github/PULL_REQUEST_TEMPLATE/release-checklist.md index 73138a83..6a1c1296 100644 --- a/.github/PULL_REQUEST_TEMPLATE/release-checklist.md +++ b/.github/PULL_REQUEST_TEMPLATE/release-checklist.md @@ -76,6 +76,16 @@ fastmod --extensions rs,toml,md --fixed-strings '0.2.0' '0.2.1' tower-batch We skipped `tower-fallback`, because it hadn't changed since the last tag. +### Reviewing Version Bump Pull Requests + +Check for missed changes by going to: +`https://github.com/ZcashFoundation/zebra/tree//` +Where `` is the hash of the last commit in the version bump PR. + +If any Zebra or Tower crates have commit messages that are **not** a version bump, we have missed an update. + +Also check for crates that depend on crates that have changed. They should get a version bump as well. + ## Initial Testing - [ ] After any changes, test that the `cargo install` command in `README.md` works (use `--path` instead of `--git` locally)