octo
/
Zebra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove unused mutability to defuse deadlock

This commit is contained in:
Jane Lusby 2020-11-30 16:47:44 -08:00 committed by Deirdre Connolly
parent 4d5ea4897c
commit fceef849cf
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zebrad/src/components/tracing/component.rs
View File

@ -55,7 +55,7 @@ impl Tracing {
/// Reload the currently-active filter with the supplied value. /// Reload the currently-active filter with the supplied value.
/// ///
/// This can be used to provide a dynamic tracing filter endpoint. /// This can be used to provide a dynamic tracing filter endpoint.
pub fn reload_filter(&mut self, filter: impl Into<EnvFilter>) { pub fn reload_filter(&self, filter: impl Into<EnvFilter>) {
self.filter_handle self.filter_handle
.reload(filter) .reload(filter)
.expect("the subscriber is not dropped before the component is"); .expect("the subscriber is not dropped before the component is");

6
zebrad/src/components/tracing/endpoint.rs
View File

@ -104,10 +104,10 @@ To set the filter, POST the new filter string to /filter:
.expect("response with known status code cannot fail"), .expect("response with known status code cannot fail"),
(&Method::POST, "/filter") => match read_filter(req).await { (&Method::POST, "/filter") => match read_filter(req).await {
Ok(filter) => { Ok(filter) => {
app_writer() app_reader()
.state_mut() .state()
.components .components
.get_downcast_mut::<Tracing>() .get_downcast_ref::<Tracing>()
.expect("Tracing component should be available") .expect("Tracing component should be available")
.reload_filter(filter); .reload_filter(filter);