8825a52bb8
Move transaction download and verify stream into the mempool service ( #2741 )
...
* Move transaction dowloader and verifier into the mempool service
* add test for `Storage::contains_rejected()`
* Rename DownloadAndVerify->Queue; move should_download_or_verify() to previous impl
* GossipedTx -> Gossip
* Revamp error handling
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
2021-09-13 16:28:07 -04:00
a2993e8df0
Skip download and verification if the transaction is already in the mempool or state ( #2718 )
...
* Check if tx already exists in mempool or state before downloading
* Reorder checks
* Add rejected test; refactor into separate function
* Wrap mempool in buffered service
* Rename RejectedTransactionsById -> RejectedTransactionsIds
* Add RejectedTransactionIds response; fix request name
* Organize imports
* add a test for Storage::rejected_transactions
* add test for mempool `Request::RejectedTransactionIds`
* change buffer size to 1 in the test
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
2021-09-08 18:51:17 +00:00
65e308d2e1
Respond to inbound `TransactionsById` with mempool content ( #2725 )
...
* reply to inbound `TransactionsById` requests
* apply style/redability suggestions and fix typo
Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
2021-09-06 22:55:17 +00:00
9c220afdc8
Reply to `Request::MempoolTransactionIds` with mempool content ( #2720 )
...
* reply to `Request::MempoolTransactionIds`
* remove boilerplate
* get storage from mempool with a method
* change panic message
* try fix for mac
* use normal init instead of init_tests for state service
* newline
* rustfmt
* fix test build
2021-09-02 13:42:31 +00:00
1ccb2de7c7
Add transaction downloader and verifier ( #2679 )
...
* Add transaction downloader
* Changed mempool downloader to be like inbound
* Verifier working (logs result)
* Apply suggestions from code review
Co-authored-by: teor <teor@riseup.net>
* Apply suggestions from code review
Co-authored-by: teor <teor@riseup.net>
* Fix coinbase check for mempool, improve is_coinbase() docs
* Change other downloads.rs docs to reflect the mempool downloads.rs changes
* Change TIMEOUTs to downloads.rs; add docs
* Renamed is_coinbase() to has_valid_coinbase_transaction_inputs() and contains_coinbase_input() to has_any_coinbase_inputs(); reorder checks
* Validate network upgrade for V4 transactions; check before computing sighash (for V5 too)
* Add block_ prefix to downloads and verifier
* Update zebra-consensus/src/transaction.rs
Co-authored-by: teor <teor@riseup.net>
* Add consensus doc; add more Block prefixes
Co-authored-by: teor <teor@riseup.net>
2021-09-02 00:06:20 +00:00
74e155ff9f
Spelling: gossipped -> gossiped ( #2119 )
2021-05-07 13:01:11 +02:00
306fa88214
Document the correctness of Poll::Pending wakeups
2021-03-27 08:55:49 -04:00
829a6f11c5
Document the behaviour of the `select!` macro
2021-03-27 08:55:49 -04:00
c6358b157c
Reduce inbound concurrency to limit memory usage
...
Inbound malicious blocks can use a large amount of RAM when
deserialized. Limit inbound concurrency, so that the total amount
of RAM remains small.
2021-03-11 06:24:46 -05:00
0b76352468
Document a state_contains bug ( #1715 )
...
* Document a state_contains bug in the syncer and Inbound
2021-02-10 09:05:14 +10:00
21b0360114
Limit concurrent inbound gossipped block requests
...
Uses the "load shed directly" design pattern from #1618 .
2021-01-29 11:02:26 +10:00
92d95d4be5
Refactor inbound members into a consistent order
...
And add download comments
2021-01-13 20:46:25 -05:00
fa02b266ca
clippy
2020-11-25 10:55:44 -08:00
de8415dcb1
tidy spans
2020-11-25 10:55:44 -08:00
77bf327b07
fix errors (2)
2020-11-25 10:55:44 -08:00
527f4d39ed
fix errors
2020-11-25 10:55:44 -08:00
e645e3bf0c
remove async
2020-11-25 10:55:44 -08:00
486e55104a
create Downloads for Inbound
2020-11-25 10:55:44 -08:00
Conrado Gouvea
Alfredo Garcia
teor
Henry de Valence