6 Commits

Author	SHA1	Message	Date
Alfredo Garcia	97fb85dca9	lint(clippy): add `unwrap_in_result` lint (#4667) ... * `unwrap_in_result` in zebra-chain crate * `unwrap_in_result` in zebra-script crate * `unwrap_in_result` in zebra-state crate * `unwrap_in_result` in zebra-consensus crate * `unwrap_in_result` in zebra-test crate * `unwrap_in_result` in zebra-network crate * `unwrap_in_result` in zebra-rpc crate * `unwrap_in_result` in zebrad crate * rustfmt * revert `?` and add exceptions * explain some panics better * move some lint positions * replace a panic with error * Fix rustfmt? Co-authored-by: teor <teor@riseup.net>	2022-06-28 06:22:07 +00:00
Deirdre Connolly	9734ea1014	Check jubjub key correctness independent of redjubjub / jubjub (#3154) ... * Ensure that sapling::keys::TransmissionKey jubjub point is always in the prime order group * Adjust TransmissionKey check; add AuthorizingKey check * Move ValueCommitment small order check to deserialization * Apply suggestions from code review Co-authored-by: Deirdre Connolly <deirdre@zfnd.org> * Use is_torsion_free() instead of is_identity() and is_prime_order() * Add EphemeralPublicKey small order check on instantiation; remove old checks * Use VerificationKey instead of VerificationKeyBytes; fix tests * Use ValidatingKey instead of VerificationKeyBytes for rk * Reject identity when creating an Orchard EphemeralPublicKey * Make documentation more consistent, use generator in tests * s/JubJub/Jubjub/ * Fix zebra-consensus tests (insert_fake_orchard_shielded_data) * Create NotSmallOrderValueCommitment, since intermediate values can be the identity * Clarify documentation * rustdoc * Tidy rustdoc Co-authored-by: Conrado Gouvea <conrado@zfnd.org> Co-authored-by: Pili Guerra <mpguerra@users.noreply.github.com>	2021-12-22 15:10:34 +00:00
Deirdre Connolly	1fa41ff199	Use new bech32 methods that expect a Variant enum variant	2021-02-21 20:51:43 -05:00
Alfredo Garcia	128643d81e	Call `zebra_test::init` where needed. (#1227) ... * Add missing `zebra_test::init()` to zebra-chain * Add missing `zebra_test::init()` to zebra-consensus * Add missing `zebra_test::init()` to zebra-network * Add missing `zebra_test::init()` to zebra-state * Add missing `zebra_test::init()` to zebra-test * Add missing `zebra_test::init()` to zebrad	2020-11-10 10:29:25 +10:00
Deirdre Connolly	c027cfc0d2	Rename SaplingShieldedAddress to Address, make address & commitment private, export their structs	2020-08-28 04:46:31 -04:00
Henry de Valence	e06f59ee21	chain: extract sapling code to sapling module	2020-08-17 11:46:34 -07:00