//! Zcash peer connection protocol handing for Zebra. //! //! Maps the external Zcash/Bitcoin protocol to Zebra's internal request/response //! protocol. //! //! This module contains a lot of undocumented state, assumptions and invariants. //! And it's unclear if these assumptions match the `zcashd` implementation. //! It should be refactored into a cleaner set of request/response pairs (#1515). use std::{ collections::HashSet, convert::{TryFrom, TryInto}, sync::Arc, }; use futures::{ future::{self, Either}, prelude::*, stream::Stream, }; use tokio::time::{sleep, Sleep}; use tower::Service; use tracing_futures::Instrument; use zebra_chain::{ block::{self, Block}, serialization::SerializationError, transaction::{self, Transaction}, }; use crate::{ constants, protocol::{ external::{types::Nonce, InventoryHash, Message}, internal::{Request, Response}, }, BoxError, }; use super::{ ClientRequestReceiver, InProgressClientRequest, MustUseOneshotSender, PeerError, SharedPeerError, }; #[derive(Debug)] pub(super) enum Handler { /// Indicates that the handler has finished processing the request. /// An error here is scoped to the request. Finished(Result), Ping(Nonce), Peers, FindBlocks, FindHeaders, BlocksByHash { hashes: HashSet, blocks: Vec>, }, TransactionsByHash { hashes: HashSet, transactions: Vec>, }, MempoolTransactions, } impl Handler { /// Try to handle `msg` as a response to a client request, possibly consuming /// it in the process. /// /// This function is where we statefully interpret Bitcoin/Zcash messages /// into responses to messages in the internal request/response protocol. /// This conversion is done by a sequence of (request, message) match arms, /// each of which contains the conversion logic for that pair. /// /// Taking ownership of the message means that we can pass ownership of its /// contents to responses without additional copies. If the message is not /// interpretable as a response, we return ownership to the caller. /// /// Unexpected messages are left unprocessed, and may be rejected later. fn process_message(&mut self, msg: Message) -> Option { let mut ignored_msg = None; // XXX can this be avoided? let tmp_state = std::mem::replace(self, Handler::Finished(Ok(Response::Nil))); *self = match (tmp_state, msg) { (Handler::Ping(req_nonce), Message::Pong(rsp_nonce)) => { if req_nonce == rsp_nonce { Handler::Finished(Ok(Response::Nil)) } else { Handler::Ping(req_nonce) } } (Handler::Peers, Message::Addr(addrs)) => Handler::Finished(Ok(Response::Peers(addrs))), // `zcashd` returns requested transactions in a single batch of messages. // Other transaction or non-transaction messages can come before or after the batch. // After the transaction batch, `zcashd` sends `NotFound` if any transactions are missing: // https://github.com/zcash/zcash/blob/e7b425298f6d9a54810cb7183f00be547e4d9415/src/main.cpp#L5617 ( Handler::TransactionsByHash { mut hashes, mut transactions, }, Message::Tx(transaction), ) => { // assumptions: // - the transaction messages are sent in a single continous batch // - missing transaction hashes are included in a `NotFound` message if hashes.remove(&transaction.hash()) { // we are in the middle of the continous transaction messages transactions.push(transaction); if hashes.is_empty() { Handler::Finished(Ok(Response::Transactions(transactions))) } else { Handler::TransactionsByHash { hashes, transactions, } } } else { // We got a transaction we didn't ask for. If the caller doesn't know any of the // transactions, they should have sent a `NotFound` with all the hashes, rather // than an unsolicited transaction. // // So either: // 1. The peer implements the protocol badly, skipping `NotFound`. // We should cancel the request, so we don't hang waiting for transactions // that will never arrive. // 2. The peer sent an unsolicited transaction. // We should ignore the transaction, and wait for the actual response. // // We end the request, so we don't hang on bad peers (case 1). But we keep the // connection open, so the inbound service can process transactions from good // peers (case 2). ignored_msg = Some(Message::Tx(transaction)); if !transactions.is_empty() { // if our peers start sending mixed solicited and unsolicited transactions, // we should update this code to handle those responses error!("unexpected transaction from peer: transaction responses should be sent in a continuous batch, followed by notfound. Using partial received transactions as the peer response"); // TODO: does the caller need a list of missing transactions? (#1515) Handler::Finished(Ok(Response::Transactions(transactions))) } else { // TODO: is it really an error if we ask for a transaction hash, but the peer // doesn't know it? Should we close the connection on that kind of error? // Should we fake a NotFound response here? (#1515) let items = hashes.iter().map(|h| InventoryHash::Tx(*h)).collect(); Handler::Finished(Err(PeerError::NotFound(items))) } } } // `zcashd` peers actually return this response ( Handler::TransactionsByHash { hashes, transactions, }, Message::NotFound(items), ) => { // assumptions: // - the peer eventually returns a transaction or a `NotFound` entry // for each hash // - all `NotFound` entries are contained in a single message // - the `NotFound` message comes after the transaction messages // // If we're in sync with the peer, then the `NotFound` should contain the remaining // hashes from the handler. If we're not in sync with the peer, we should return // what we got so far, and log an error. let missing_transactions: HashSet<_> = items .iter() .filter_map(|inv| match &inv { InventoryHash::Tx(tx) => Some(tx), _ => None, }) .cloned() .collect(); if missing_transactions != hashes { trace!(?items, ?missing_transactions, ?hashes); // if these errors are noisy, we should replace them with debugs error!("unexpected notfound message from peer: all remaining transaction hashes should be listed in the notfound. Using partial received transactions as the peer response"); } if missing_transactions.len() != items.len() { trace!(?items, ?missing_transactions, ?hashes); error!("unexpected notfound message from peer: notfound contains duplicate hashes or non-transaction hashes. Using partial received transactions as the peer response"); } if !transactions.is_empty() { // TODO: does the caller need a list of missing transactions? (#1515) Handler::Finished(Ok(Response::Transactions(transactions))) } else { // TODO: is it really an error if we ask for a transaction hash, but the peer // doesn't know it? Should we close the connection on that kind of error? (#1515) Handler::Finished(Err(PeerError::NotFound(items))) } } // `zcashd` returns requested blocks in a single batch of messages. // Other blocks or non-blocks messages can come before or after the batch. // `zcashd` silently skips missing blocks, rather than sending a final `NotFound` message. // https://github.com/zcash/zcash/blob/e7b425298f6d9a54810cb7183f00be547e4d9415/src/main.cpp#L5523 ( Handler::BlocksByHash { mut hashes, mut blocks, }, Message::Block(block), ) => { // assumptions: // - the block messages are sent in a single continuous batch // - missing blocks are silently skipped // (there is no `NotFound` message at the end of the batch) if hashes.remove(&block.hash()) { // we are in the middle of the continuous block messages blocks.push(block); if hashes.is_empty() { Handler::Finished(Ok(Response::Blocks(blocks))) } else { Handler::BlocksByHash { hashes, blocks } } } else { // We got a block we didn't ask for. // // So either: // 1. The peer doesn't know any of the blocks we asked for. // We should cancel the request, so we don't hang waiting for blocks that // will never arrive. // 2. The peer sent an unsolicited block. // We should ignore that block, and wait for the actual response. // // We end the request, so we don't hang on forked or lagging peers (case 1). // But we keep the connection open, so the inbound service can process blocks // from good peers (case 2). ignored_msg = Some(Message::Block(block)); if !blocks.is_empty() { // TODO: does the caller need a list of missing blocks? (#1515) Handler::Finished(Ok(Response::Blocks(blocks))) } else { // TODO: is it really an error if we ask for a block hash, but the peer // doesn't know it? Should we close the connection on that kind of error? // Should we fake a NotFound response here? (#1515) let items = hashes.iter().map(|h| InventoryHash::Block(*h)).collect(); Handler::Finished(Err(PeerError::NotFound(items))) } } } // peers are allowed to return this response, but `zcashd` never does (Handler::BlocksByHash { hashes, blocks }, Message::NotFound(items)) => { // assumptions: // - the peer eventually returns a block or a `NotFound` entry // for each hash // - all `NotFound` entries are contained in a single message // - the `NotFound` message comes after the block messages // // If we're in sync with the peer, then the `NotFound` should contain the remaining // hashes from the handler. If we're not in sync with the peer, we should return // what we got so far, and log an error. let missing_blocks: HashSet<_> = items .iter() .filter_map(|inv| match &inv { InventoryHash::Block(b) => Some(b), _ => None, }) .cloned() .collect(); if missing_blocks != hashes { trace!(?items, ?missing_blocks, ?hashes); // if these errors are noisy, we should replace them with debugs error!("unexpected notfound message from peer: all remaining block hashes should be listed in the notfound. Using partial received blocks as the peer response"); } if missing_blocks.len() != items.len() { trace!(?items, ?missing_blocks, ?hashes); error!("unexpected notfound message from peer: notfound contains duplicate hashes or non-block hashes. Using partial received blocks as the peer response"); } if !blocks.is_empty() { // TODO: does the caller need a list of missing blocks? (#1515) Handler::Finished(Ok(Response::Blocks(blocks))) } else { // TODO: is it really an error if we ask for a block hash, but the peer // doesn't know it? Should we close the connection on that kind of error? (#1515) Handler::Finished(Err(PeerError::NotFound(items))) } } (Handler::FindBlocks, Message::Inv(items)) if items .iter() .all(|item| matches!(item, InventoryHash::Block(_))) => { Handler::Finished(Ok(Response::BlockHashes( block_hashes(&items[..]).collect(), ))) } (Handler::MempoolTransactions, Message::Inv(items)) if items .iter() .all(|item| matches!(item, InventoryHash::Tx(_))) => { Handler::Finished(Ok(Response::TransactionHashes( transaction_hashes(&items[..]).collect(), ))) } (Handler::FindHeaders, Message::Headers(headers)) => { Handler::Finished(Ok(Response::BlockHeaders(headers))) } // By default, messages are not responses. (state, msg) => { trace!(?msg, "did not interpret message as response"); ignored_msg = Some(msg); state } }; ignored_msg } } #[derive(Debug)] #[must_use = "AwaitingResponse.tx.send() must be called before drop"] pub(super) enum State { /// Awaiting a client request or a peer message. AwaitingRequest, /// Awaiting a peer message we can interpret as a client request. AwaitingResponse { handler: Handler, tx: MustUseOneshotSender>, span: tracing::Span, }, } impl State { async fn step(self, conn: &mut Connection, peer_rx: &mut Rx) -> Transition where Rx: Stream> + Unpin, S: Service, S::Error: Into, Tx: Sink + Unpin, { match self { State::AwaitingRequest => { trace!("awaiting client request or peer message"); match future::select(peer_rx.next(), conn.client_rx.next()).await { Either::Left((None, _)) => { Transition::Close(PeerError::ConnectionClosed.into()) } Either::Left((Some(Err(e)), _)) => Transition::Close(e.into()), Either::Left((Some(Ok(msg)), _)) => { match conn.handle_message_as_request(msg).await { Ok(()) => Transition::AwaitRequest, Err(e) => Transition::Close(e.into()), } } Either::Right((None, _)) => { trace!("client_rx closed, ending connection"); Transition::ClientClose } Either::Right((Some(req), _)) => { if req.tx.is_canceled() { metrics::counter!("peer.canceled", 1); tracing::debug!("ignoring canceled request"); return Transition::AwaitRequest; } let span = req.span.clone(); conn.handle_client_request(req).instrument(span).await } } } // We're awaiting a response to a client request, // so wait on either a peer message, or on a request cancellation. State::AwaitingResponse { span, mut tx, mut handler, } => { // we have to get rid of the span reference so we can tamper with the state let span = span.clone(); trace!(parent: &span, "awaiting response to client request"); let timer_ref = conn .request_timer .as_mut() .expect("timeout must be set while awaiting response"); let cancel = future::select(timer_ref, tx.cancellation()); match future::select(peer_rx.next(), cancel) .instrument(span.clone()) .await { Either::Left((None, _)) => Transition::CloseResponse { e: PeerError::ConnectionClosed.into(), tx, }, Either::Left((Some(Err(e)), _)) => { Transition::CloseResponse { e: e.into(), tx } } Either::Left((Some(Ok(peer_msg)), _cancel)) => { let request_msg = span.in_scope(|| handler.process_message(peer_msg)); // If the message was not consumed, check whether it // should be handled as a request. if let Some(msg) = request_msg { // do NOT instrument with the request span, this is // independent work match conn.handle_message_as_request(msg).await { Ok(()) => { Transition::AwaitResponse { tx, handler, span } // Transition::AwaitRequest } Err(e) => Transition::CloseResponse { e: e.into(), tx }, } } else { // Otherwise, check whether the handler is finished // processing messages and update the state. match handler { Handler::Finished(response) => { let _ = tx.send(response.map_err(Into::into)); Transition::AwaitRequest } _ => Transition::AwaitResponse { tx, handler, span }, } } } Either::Right((Either::Left(_), _peer_fut)) => { trace!(parent: &span, "client request timed out"); let e = PeerError::ClientRequestTimeout; match handler { Handler::Ping(_) => Transition::CloseResponse { e: e.into(), tx }, _ => { let _ = tx.send(Err(e.into())); Transition::AwaitRequest } } } Either::Right((Either::Right(_), _peer_fut)) => { trace!(parent: &span, "client request was cancelled"); Transition::AwaitRequest } } } } } } /// Enum describing the next state transition that should be taken after any /// given `step`. enum Transition { AwaitRequest, AwaitResponse { handler: Handler, tx: MustUseOneshotSender>, span: tracing::Span, }, /// Closing because the client was closed or dropped, and there are /// no more client requests. ClientClose, /// Closing while awaiting further client requests Close(SharedPeerError), /// Closing while processing a peer response to a client request CloseResponse { tx: MustUseOneshotSender>, e: SharedPeerError, }, } impl TryFrom for State { type Error = Option; fn try_from(trans: Transition) -> Result { match trans { Transition::AwaitRequest => Ok(State::AwaitingRequest), Transition::AwaitResponse { handler, tx, span } => { Ok(State::AwaitingResponse { handler, tx, span }) } Transition::ClientClose => Err(None), Transition::Close(e) => Err(Some(e)), Transition::CloseResponse { tx, e } => { let _ = tx.send(Err(e.clone())); Err(Some(e)) } } } } /// The state associated with a peer connection. pub struct Connection { pub(super) state: Option, /// A timeout for a client request. This is stored separately from /// State so that we can move the future out of it independently of /// other state handling. pub(super) request_timer: Option, pub(super) svc: S, /// A `mpsc::Receiver` that converts its results to /// `InProgressClientRequest` pub(super) client_rx: ClientRequestReceiver, //pub(super) peer_rx: Rx, pub(super) peer_tx: Tx, } impl Connection where S: Service, S::Error: Into, Tx: Sink + Unpin, { /// Consume this `Connection` to form a spawnable future containing its event loop. pub async fn run(mut self, mut peer_rx: Rx) where Rx: Stream> + Unpin, { // At a high level, the event loop we want is as follows: we check for any // incoming messages from the remote peer, check if they should be interpreted // as a response to a pending client request, and if not, interpret them as a // request from the remote peer to our node. // // We also need to handle those client requests in the first place. The client // requests are received from the corresponding `peer::Client` over a bounded // channel (with bound 1, to minimize buffering), but there is no relationship // between the stream of client requests and the stream of peer messages, so we // cannot ignore one kind while waiting on the other. Moreover, we cannot accept // a second client request while the first one is still pending. // // To do this, we inspect the current request state. // // If there is no pending request, we wait on either an incoming peer message or // an incoming request, whichever comes first. // // If there is a pending request, we wait only on an incoming peer message, and // check whether it can be interpreted as a response to the pending request. loop { let transition = self .state .take() .expect("state only None during steps") .step(&mut self, &mut peer_rx) .await; if matches!(transition, Transition::AwaitResponse { .. }) { self.request_timer = Some(sleep(constants::REQUEST_TIMEOUT)); } self.state = match transition.try_into() { Ok(state) => Some(state), Err(None) => { trace!("client_rx dropped: no pending client requests"); return; } Err(Some(e)) => { while let Some(InProgressClientRequest { tx, span, .. }) = self.client_rx.next().await { trace!( parent: &span, "sending an error response to a pending client request on a failed connection" ); let _ = tx.send(Err(e.clone())); } return; } } } } /// Handle an incoming client request, possibly generating outgoing messages to the /// remote peer. /// /// Correctness: This function MUST only be called while in the AwaitingRequest state /// /// NOTE: the caller should use .instrument(msg.span) to instrument the function. async fn handle_client_request(&mut self, req: InProgressClientRequest) -> Transition { trace!(?req.request); use Request::*; let InProgressClientRequest { request, tx, span } = req; // common logic for client requests without an expected response fn continue_without_response( tx: MustUseOneshotSender>, ) -> Transition { // Since we're not waiting for further messages, we need to // send a response before dropping tx. let _ = tx.send(Ok(Response::Nil)); Transition::AwaitRequest } match request { Peers => match self.peer_tx.send(Message::GetAddr).await { Ok(()) => Transition::AwaitResponse { handler: Handler::Peers, tx, span, }, Err(e) => Transition::CloseResponse { e: e.into(), tx }, }, Ping(nonce) => match self.peer_tx.send(Message::Ping(nonce)).await { Ok(()) => Transition::AwaitResponse { handler: Handler::Ping(nonce), tx, span, }, Err(e) => Transition::CloseResponse { e: e.into(), tx }, }, BlocksByHash(hashes) => { match self .peer_tx .send(Message::GetData( hashes.iter().map(|h| (*h).into()).collect(), )) .await { Ok(()) => Transition::AwaitResponse { handler: Handler::BlocksByHash { blocks: Vec::with_capacity(hashes.len()), hashes, }, tx, span, }, Err(e) => Transition::CloseResponse { e: e.into(), tx }, } } TransactionsByHash(hashes) => { match self .peer_tx .send(Message::GetData( hashes.iter().map(|h| (*h).into()).collect(), )) .await { Ok(()) => Transition::AwaitResponse { handler: Handler::TransactionsByHash { transactions: Vec::with_capacity(hashes.len()), hashes, }, tx, span, }, Err(e) => Transition::CloseResponse { e: e.into(), tx }, } } FindBlocks { known_blocks, stop } => { match self .peer_tx .send(Message::GetBlocks { known_blocks, stop }) .await { Ok(()) => Transition::AwaitResponse { handler: Handler::FindBlocks, tx, span, }, Err(e) => Transition::CloseResponse { e: e.into(), tx }, } } FindHeaders { known_blocks, stop } => { match self .peer_tx .send(Message::GetHeaders { known_blocks, stop }) .await { Ok(()) => Transition::AwaitResponse { handler: Handler::FindHeaders, tx, span, }, Err(e) => Transition::CloseResponse { e: e.into(), tx }, } } MempoolTransactions => match self.peer_tx.send(Message::Mempool).await { Ok(()) => Transition::AwaitResponse { handler: Handler::MempoolTransactions, tx, span, }, Err(e) => Transition::CloseResponse { e: e.into(), tx }, }, PushTransaction(transaction) => { match self.peer_tx.send(Message::Tx(transaction)).await { Ok(()) => continue_without_response(tx), Err(e) => Transition::CloseResponse { e: e.into(), tx }, } } AdvertiseTransactions(hashes) => { match self .peer_tx .send(Message::Inv(hashes.iter().map(|h| (*h).into()).collect())) .await { Ok(()) => continue_without_response(tx), Err(e) => Transition::CloseResponse { e: e.into(), tx }, } } AdvertiseBlock(hash) => { match self.peer_tx.send(Message::Inv(vec![hash.into()])).await { Ok(()) => continue_without_response(tx), Err(e) => Transition::CloseResponse { e: e.into(), tx }, } } } } // This function has its own span, because we're creating a new work // context (namely, the work of processing the inbound msg as a request) #[instrument(name = "msg_as_req", skip(self, msg), fields(%msg))] async fn handle_message_as_request(&mut self, msg: Message) -> Result<(), PeerError> { trace!(?msg); let req = match msg { Message::Ping(nonce) => { trace!(?nonce, "responding to heartbeat"); self.peer_tx.send(Message::Pong(nonce)).await?; return Ok(()); } // These messages shouldn't be sent outside of a handshake. Message::Version { .. } => Err(PeerError::DuplicateHandshake)?, Message::Verack { .. } => Err(PeerError::DuplicateHandshake)?, // These messages should already be handled as a response if they // could be a response, so if we see them here, they were either // sent unsolicited, or they were sent in response to a canceled request // that we've already forgotten about. Message::Reject { .. } => { tracing::debug!("got reject message unsolicited or from canceled request"); return Ok(()); } Message::NotFound { .. } => { tracing::debug!("got notfound message unsolicited or from canceled request"); return Ok(()); } Message::Pong(_) => { tracing::debug!("got pong message unsolicited or from canceled request"); return Ok(()); } Message::Block(_) => { tracing::debug!("got block message unsolicited or from canceled request"); return Ok(()); } Message::Headers(_) => { tracing::debug!("got headers message unsolicited or from canceled request"); return Ok(()); } // These messages should never be sent by peers. Message::FilterLoad { .. } | Message::FilterAdd { .. } | Message::FilterClear { .. } => Err(PeerError::UnsupportedMessage( "got BIP11 message without advertising NODE_BLOOM", ))?, // Zebra crawls the network proactively, to prevent // peers from inserting data into our address book. Message::Addr(_) => { trace!("ignoring unsolicited addr message"); return Ok(()); } Message::Tx(transaction) => Request::PushTransaction(transaction), Message::Inv(items) => match &items[..] { // We don't expect to be advertised multiple blocks at a time, // so we ignore any advertisements of multiple blocks. [InventoryHash::Block(hash)] => Request::AdvertiseBlock(*hash), [InventoryHash::Tx(_), rest @ ..] if rest.iter().all(|item| matches!(item, InventoryHash::Tx(_))) => { Request::TransactionsByHash(transaction_hashes(&items).collect()) } _ => Err(PeerError::WrongMessage("inv with mixed item types"))?, }, Message::GetData(items) => match &items[..] { [InventoryHash::Block(_), rest @ ..] if rest .iter() .all(|item| matches!(item, InventoryHash::Block(_))) => { Request::BlocksByHash(block_hashes(&items).collect()) } [InventoryHash::Tx(_), rest @ ..] if rest.iter().all(|item| matches!(item, InventoryHash::Tx(_))) => { Request::TransactionsByHash(transaction_hashes(&items).collect()) } _ => Err(PeerError::WrongMessage("getdata with mixed item types"))?, }, Message::GetAddr => Request::Peers, Message::GetBlocks { known_blocks, stop } => Request::FindBlocks { known_blocks, stop }, Message::GetHeaders { known_blocks, stop } => { Request::FindHeaders { known_blocks, stop } } Message::Mempool => Request::MempoolTransactions, }; self.drive_peer_request(req).await?; Ok(()) } /// Given a `req` originating from the peer, drive it to completion and send /// any appropriate messages to the remote peer. If an error occurs while /// processing the request (e.g., the service is shedding load), then we /// return a peer error, which terminates the entire peer connection, /// shrinking the number of connected peers. async fn drive_peer_request(&mut self, req: Request) -> Result<(), PeerError> { trace!(?req); use tower::{load_shed::error::Overloaded, ServiceExt}; if self.svc.ready_and().await.is_err() { // Treat all service readiness errors as Overloaded // TODO: treat `TryRecvError::Closed` in `Inbound::poll_ready` as a fatal error (#1655) Err(PeerError::Overloaded)? } let rsp = match self.svc.call(req).await { Err(e) => { if e.is::() { tracing::warn!("inbound service is overloaded, closing connection"); metrics::counter!("pool.closed.loadshed", 1); Err(PeerError::Overloaded)? } else { // We could send a reject to the remote peer, but that might cause // them to disconnect, and we might be using them to sync blocks. // For similar reasons, we don't return an error - we only close // the connection if the peer is doing something wrong. error!(%e, connection_state = ?self.state, client_receiver = ?self.client_rx, "error processing peer request"); } return Ok(()); } Ok(rsp) => rsp, }; match rsp { Response::Nil => { /* generic success, do nothing */ } Response::Peers(addrs) => self.peer_tx.send(Message::Addr(addrs)).await?, Response::Transactions(transactions) => { // Generate one tx message per transaction. for transaction in transactions.into_iter() { self.peer_tx.send(Message::Tx(transaction)).await?; } } Response::Blocks(blocks) => { // Generate one block message per block. for block in blocks.into_iter() { self.peer_tx.send(Message::Block(block)).await?; } } Response::BlockHashes(hashes) => { self.peer_tx .send(Message::Inv(hashes.into_iter().map(Into::into).collect())) .await? } Response::BlockHeaders(headers) => self.peer_tx.send(Message::Headers(headers)).await?, Response::TransactionHashes(hashes) => { self.peer_tx .send(Message::Inv(hashes.into_iter().map(Into::into).collect())) .await? } } Ok(()) } } fn transaction_hashes(items: &'_ [InventoryHash]) -> impl Iterator + '_ { items.iter().filter_map(|item| { if let InventoryHash::Tx(hash) = item { Some(*hash) } else { None } }) } fn block_hashes(items: &'_ [InventoryHash]) -> impl Iterator + '_ { items.iter().filter_map(|item| { if let InventoryHash::Block(hash) = item { Some(*hash) } else { None } }) }