octo
/
Zebra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update comments for the inbound service (#1740)

This commit is contained in:
teor 2021-02-16 06:14:40 +10:00 committed by GitHub
parent 372a432179
commit cc7d5bd2ad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
zebrad/src/components/inbound.rs
View File

@ -69,9 +69,6 @@ pub enum Setup {
/// Network setup failed, because the setup channel permanently failed. /// Network setup failed, because the setup channel permanently failed.
/// The service keeps returning readiness errors for every request. /// The service keeps returning readiness errors for every request.
///
/// We keep hold of the closed oneshot, so we can use it to create a
/// new error for each `poll_ready` call.
FailedRecv { error: SharedRecvError }, FailedRecv { error: SharedRecvError },
} }
@ -221,8 +218,8 @@ impl Service<zn::Request> for Inbound {
// "load shed directly" pattern from #1618. // "load shed directly" pattern from #1618.
// * currently, the state service is always ready, unless its buffer is full. // * currently, the state service is always ready, unless its buffer is full.
// So we might also want to propagate backpressure from its buffer. // So we might also want to propagate backpressure from its buffer.
// * if we want to propagate backpressure, add a ReadyCache for each service, to ensure // * poll_ready needs to be implemented carefully, to avoid hangs or deadlocks.
// that each poll_ready has a matching call. See #1593 for details. // See #1593 for details.
Poll::Ready(result) Poll::Ready(result)
} }