aa70db1867
consensus: remove dead code in checkpointer
...
This was never used anywhere, not even by tests, but nothing noticed
because it had an #[allow(dead_code)].
2020-09-11 13:37:49 -07:00
de2400031c
state: merge SledState::{queue, process_queue}.
...
We never want to call one without the other, so just do them together.
2020-09-11 13:37:49 -07:00
93586867bc
consensus: change verifier poll_ready handling.
...
This makes the component verifiers both always return `poll_ready`,
because they do not exert backpressure and cannot fail.
The checkpoint verifier now immediately rejects any blocks that arrive
after it finishes checkpointing, instead of marking the service itself
as failed.
The chain verifier is agnostic to the readiness behavior of its
components, and reports readiness when they are both ready.
2020-09-11 13:37:49 -07:00
526f771ceb
state: update SledState docs.
2020-09-11 13:37:49 -07:00
8fb0e11674
fix: clippy-redundant closures, fmt
2020-09-11 13:37:49 -07:00
0d6303a56f
consensus: avoid tower::ServiceExt::oneshot()
...
This is a really nice function but there might be a bug in its future
implementation: https://github.com/tower-rs/tower/issues/469
This bug may have already been fixed for the 0.4.0 release, so we could change
back then.
2020-09-11 13:37:49 -07:00
006596b9a9
state: remove unused variables
2020-09-11 13:37:49 -07:00
f4db12efcb
state: implement Request::Block with sled
2020-09-11 13:37:49 -07:00
2cbc60aeae
consensus: fix block-not-in-state check in test
...
The state responds with Ok(None) when the block is not there, and Err(_) to
indicate an error while looking.
2020-09-11 13:37:49 -07:00
a1d3af9e9c
consensus: disable contextual verification test
...
Contextual verification isn't implemented, so we can't test it yet.
2020-09-11 13:37:49 -07:00
d5bc8f937d
consensus: construct checkpointer with a tip, not a block
2020-09-11 13:37:49 -07:00
5d8decd224
state: process CommitFinalizedBlock out of order
2020-09-11 13:37:49 -07:00
b27ace87eb
state: partial implementation of new sled layout
2020-09-11 13:37:49 -07:00
f1f0b331ac
state: make Response::Tip return (height, hash)
2020-09-11 13:37:49 -07:00
3133214e4f
zebrad: use new state API
2020-09-11 13:37:49 -07:00
a25801fc2c
consensus: remove length-1 checkpoint list test
...
This test aimed to exercise both the checkpoint and block verifiers by
making a checkpoint list of length 1. However, the block verifier can't
work on any blocks below Sapling activation.
2020-09-11 13:37:49 -07:00
6dd7c6495b
consensus: make ChainVerifier a router
...
Instead of conditionally parsing the hardcoded checkpoint list and
optionally making a CheckpointVerifier, make one unconditionally, and
use the config settings to decide whether to route responses to it.
Then, fix up all of the places needed to make it compile and remove all
of the dead code.
2020-09-11 13:37:49 -07:00
93cc6957b1
consensus: partially update to new state API
...
This disables one test that can't be easily fixed at the moment, because
it tests the wrong thing: the checkpoint and block verifiers will
produce different transcripts.
It also disables the initial_tip logic for now, pending simplification
of the ChainVerifier logic.
2020-09-11 13:37:49 -07:00
070013439e
state: fill in RFC5-style Request, Response enums
...
The test transcripts need to be rewritten, so they are removed for now.
2020-09-11 13:37:49 -07:00
98d5351206
state: add rustdoc links
2020-09-11 13:37:49 -07:00
2ac8b5b9d4
state: create a new wrapper service
...
The new `StateService` type wraps a `SledState` and a `MemoryState`.
This will allow the sled-related code and the in-memory code to be kept
separate, with the top-level `StateService` making method calls to one
or the other, as appropriate.
This commit removes the existing Service impl for the SledService. This
saves time in refactoring, and the code needs to be rewritten
anyways so there's no loss to deleting it now.
2020-09-11 13:37:49 -07:00
303b02d10a
state: split into modules and reorganize
...
Closes #975 .
2020-09-11 13:37:49 -07:00
69032e1007
build(deps): bump sled from 0.34.3 to 0.34.4
...
Bumps [sled](https://github.com/spacejam/sled ) from 0.34.3 to 0.34.4.
- [Release notes](https://github.com/spacejam/sled/releases )
- [Changelog](https://github.com/spacejam/sled/blob/master/CHANGELOG.md )
- [Commits](https://github.com/spacejam/sled/compare/v0.34.3...v0.34.4 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-09-11 13:08:16 -04:00
9f07572bc4
Disable CodeCov annotations via GitHub Checks
...
They just decided to turn this on by default for all their GitHub users ...
https://docs.codecov.io/docs/github-checks-beta
2020-09-10 14:52:01 -04:00
6b88479480
Run CI workflow jobs on every PR, just like Cloud Build
2020-09-10 14:26:27 -04:00
b1e1291f45
Log inbound peer requests at debug
...
Logging at info was a bit too verbose.
Also add a short log message.
2020-09-10 09:46:53 -07:00
24de90c900
zebrad: tidy sync imports
2020-09-10 09:45:52 -07:00
9b6e66c1b9
zebrad: rename Syncer to ChainSync
...
This name clarifies what is being synced and avoids an agent-noun
construction.
2020-09-10 09:45:52 -07:00
0bc79686b8
zebrad: move sync into components module.
...
Part of #1030 .
2020-09-10 09:45:52 -07:00
b881eafe47
build(deps): bump jubjub from 0.5.0 to 0.5.1
...
Bumps [jubjub](https://github.com/zkcrypto/jubjub ) from 0.5.0 to 0.5.1.
- [Release notes](https://github.com/zkcrypto/jubjub/releases )
- [Changelog](https://github.com/zkcrypto/jubjub/blob/main/RELEASES.md )
- [Commits](https://github.com/zkcrypto/jubjub/commits )
Signed-off-by: dependabot[bot] <support@github.com>
2020-09-10 09:45:37 -07:00
9cf7de6253
Temporarily ignore failing state tests
...
This commit should be reverted when the state can handle out-of-order
blocks.
2020-09-09 15:37:59 -07:00
1cd9f48d19
Add tests for in-order state AddBlock requests
...
Also fix a bug in the tests, where Mainnet and Testnet were swapped.
2020-09-09 15:37:59 -07:00
7f2bebb97d
Stop awaiting the previous block in the block verifier
...
Instead, the state should cache blocks until the previous block has been
committed.
2020-09-09 15:37:59 -07:00
8463b705c8
Panic when state blocks are inserted out of order
...
This panic ensures our state is not corrupted. Corrupt states can lead
to future panics when querying the chain.
2020-09-09 15:37:59 -07:00
1285561c3f
Perform serialised block writes to the state
...
As per the state design RFC 0005.
2020-09-09 15:37:59 -07:00
6a79953ab6
Separate state commits into checkpoint and full block verify
...
* stop committing to the state in the ChainVerifier
* commit to the state in the BlockVerifier
* commit to the state in the CheckpointVerifier
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
2020-09-09 15:37:59 -07:00
1b76cb0250
Log message and comment cleanups
...
Also:
* Clarify the out of order block debug message
2020-09-09 15:37:59 -07:00
adafe1d189
Restart sync after the first failed ObtainTips
...
The ObtainTips retry was redundant. The timeout wasn't much shorter, but
it made the code and sync logic more complicated.
2020-09-09 15:35:09 -07:00
66265dc11a
Adjust the EWMA decay for the latest sync timeout
2020-09-09 15:35:09 -07:00
1f7af0a779
Update the inv message processing comment
...
Cleanup after PR #1028 .
2020-09-09 15:29:38 -07:00
a3984729be
build(deps): bump jubjub from 0.4.0 to 0.5.0
...
Bumps [jubjub](https://github.com/zkcrypto/jubjub ) from 0.4.0 to 0.5.0.
- [Release notes](https://github.com/zkcrypto/jubjub/releases )
- [Changelog](https://github.com/zkcrypto/jubjub/blob/main/RELEASES.md )
- [Commits](https://github.com/zkcrypto/jubjub/commits )
Signed-off-by: dependabot[bot] <support@github.com>
2020-09-09 10:31:24 -04:00
3f25da996a
Add wrapper fn is_time_valid_at in zebra_consensus::block::check
...
This commit doesn't move the fn itself because it's tests can't
depend on `generate` code which is not exposed to other crates.
2020-09-09 12:48:15 +10:00
7118e4da3c
Move is_equihash_solution_valid to zebra-consensus
2020-09-09 12:48:15 +10:00
2a68ef5acb
Update the peerset buffer size and sync timeout
...
Also add a bunch of comments and documentation for network-constrained
nodes, and for testnet.
2020-09-08 12:44:33 -07:00
b062a682b0
Refactor "waiting for pending blocks" log
2020-09-08 12:44:33 -07:00
e6e859dce2
Tweak sync timeouts
...
* increase the EWMA default and decay
* increase the block download retries
* increase the request and block download timeouts
* increase the sync timeout
2020-09-08 12:44:33 -07:00
ce12d4dadc
Add timeouts for tip responses and block verify tasks
2020-09-08 12:44:33 -07:00
379ce5c1b8
Retry obtain and extend tips on failure
2020-09-08 12:44:33 -07:00
1b17691dda
improve logging
2020-09-08 12:37:34 -07:00
81a3ad3a0d
filter inventory advertisements correctly
2020-09-08 12:37:34 -07:00
Henry de Valence
dependabot[bot]
Deirdre Connolly
teor
Ramana Venkata
Jane Lusby